Enable performance monitoring in production #9809
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rachelmcr
added
the
category: performance
Collaborator
You can test the changes from this Pull Request by:
|
wzieba
reviewed
May 24, 2023
|
|
||
| return .enabled( | ||
| .init( | ||
| // FIXME: Is there a way to control this via feature flags? |
Contributor
There was a problem hiding this comment.
About usage of feature flags - on WCAndroid we recently disabled this feature as we were relying on Firebase Remote Config for that.
But for the future, I think it might be valuable to set performance sampling to use our in-house feature flag system (when it'll be integrated).
Contributor
Author
|
Closing this draft PR for now, since there's more work needed to implement this monitoring and it's unclear when we'll prioritize that. |
Contributor
|
Just for future reference, this ended up being implemented via #7831 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This enables performance monitoring in production, sampling 1% of transactions. We're enabling this to record baseline measurements for future performance improvements.
Related (internal ref): pdnsEh-1a1-p2
Testing instructions
You can confirm the monitoring is working by installing the alpha build from this PR (which also has performance monitoring enabled), navigating the app, and checking Sentry > Performance for transactions.
RELEASE-NOTES.txtif necessary.